Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaderBase_Tests: 100% internal coverage #462

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Mar 11, 2020

This PR completes coverage for the ReaderBase_Tests.cpp file itself, by adding code to exercise the derived class that's defined in the test source. (It does nothing to affect the coverage of any libopenshot source code, merely the coverage of the source code for the unit test itself.)

@ferdnyc ferdnyc added code Source code cleanup, streamlining, or style tweaks tests Changes related to the unit tests and/or code coverage labels Mar 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #462 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
+ Coverage    43.22%   43.43%   +0.21%     
===========================================
  Files          130      130              
  Lines        12932    12943      +11     
===========================================
+ Hits          5590     5622      +32     
+ Misses        7342     7321      -21
Impacted Files Coverage Δ
tests/ReaderBase_Tests.cpp 100% <100%> (+47.61%) ⬆️
thirdparty/jsoncpp/jsoncpp.cpp 27.46% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e5c9c...4b8f00f. Read the comment docs.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 11, 2020

Merging as painfully uncontroversial.

@ferdnyc ferdnyc merged commit 4058dde into OpenShot:develop Mar 11, 2020
@ferdnyc ferdnyc deleted the readerbase-test-coverage branch March 11, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code cleanup, streamlining, or style tweaks tests Changes related to the unit tests and/or code coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants